From bf565178f696a8161cc0fe950dd3f4f7a3279789 Mon Sep 17 00:00:00 2001
From: Andrii Solianyk <asolianik2015@gmail.com>
Date: Mon, 28 Apr 2025 15:06:32 +0200
Subject: [PATCH] fix of images deletion

---
 pom.xml                                                     | 5 +++++
 .../artisanconnectbackend/controller/ImageController.java   | 6 +++---
 .../asktpk/artisanconnectbackend/service/ImageService.java  | 5 ++---
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/pom.xml b/pom.xml
index 23b7b0b..2194186 100644
--- a/pom.xml
+++ b/pom.xml
@@ -93,6 +93,11 @@
             <artifactId>jakarta.validation-api</artifactId>
             <version>3.1.0</version>
         </dependency>
+<!--        <dependency>-->
+<!--            <groupId>org.springdoc</groupId>-->
+<!--            <artifactId>springdoc-openapi-starter-webmvc-ui</artifactId>-->
+<!--            <version>2.8.5</version>-->
+<!--        </dependency>-->
     </dependencies>
 
     <build>
diff --git a/src/main/java/_11/asktpk/artisanconnectbackend/controller/ImageController.java b/src/main/java/_11/asktpk/artisanconnectbackend/controller/ImageController.java
index 9226c53..b97ff38 100644
--- a/src/main/java/_11/asktpk/artisanconnectbackend/controller/ImageController.java
+++ b/src/main/java/_11/asktpk/artisanconnectbackend/controller/ImageController.java
@@ -78,12 +78,12 @@ public class ImageController {
     }
 
     @DeleteMapping("/delete/{id}")
-    public ResponseEntity deleteImage(@PathVariable("id") String filename) {
+    public ResponseEntity<RequestResponseDTO> deleteImage(@PathVariable("id") String filename) {
         try {
             imageService.deleteImage(uploadDir, filename);
-            return new ResponseEntity<>(HttpStatus.OK);
+            return ResponseEntity.status(HttpStatus.OK).body(new RequestResponseDTO("Image deleted successfully."));
         } catch (Exception e) {
-            return new ResponseEntity<>(HttpStatus.INTERNAL_SERVER_ERROR);
+            return ResponseEntity.status(HttpStatus.INTERNAL_SERVER_ERROR).body(new RequestResponseDTO(e.getMessage()));
         }
     }
 }
diff --git a/src/main/java/_11/asktpk/artisanconnectbackend/service/ImageService.java b/src/main/java/_11/asktpk/artisanconnectbackend/service/ImageService.java
index fa3faad..eb1c639 100644
--- a/src/main/java/_11/asktpk/artisanconnectbackend/service/ImageService.java
+++ b/src/main/java/_11/asktpk/artisanconnectbackend/service/ImageService.java
@@ -60,14 +60,13 @@ public class ImageService {
         return resource;
     }
 
-    public String deleteImage(String imageDirectory, String imageName) throws IOException {
+    public void deleteImage(String imageDirectory, String imageName) throws IOException {
         Path imagePath = Path.of(imageDirectory, imageName);
 
         if (Files.exists(imagePath)) {
             Files.delete(imagePath);
-            return "Success";
         } else {
-            return "Failed"; // Handle missing images
+            throw new IOException("File not found");
         }
     }